WIP properties return values #1808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
commented
Apr 19, 2022
| } | ||
|
|
||
| /// Properties that are stored in CodePointSets | ||
| pub trait CodePointSetLikeProperty { |
There was a problem hiding this comment.
n.b. this and the other trait should just be CodePointSetProperty
CPSLike/etc haven't been introduced yet
echeran
reviewed
Apr 19, 2022
| #[cfg_attr(feature = "datagen", derive(serde::Serialize))] | ||
| #[cfg_attr(feature = "serde", derive(serde::Deserialize))] | ||
| pub struct UnicodePropertyV1<'data> { | ||
| pub struct CodePointSet<'data> { | ||
| /// The set of characters, represented as an inversion list | ||
| #[cfg_attr(feature = "serde", serde(borrow))] | ||
| pub inv_list: UnicodeSet<'data>, |
There was a problem hiding this comment.
If/when you introduce a trait CodePointSetLike to represent the behavior of the CodePointSet data struct, would you be able to use that here somehow in the type of the field? Both the field name and its current type suggest a singular concrete implementation type.
Manishearth
force-pushed
the
properties-return
branch
from
4043843
to
f29ca6c
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Manishearth
force-pushed
the
properties-return
branch
from
f29ca6c
to
ee70767
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting this up so that folks can review what I have so far before I go too deep into manually fixing the 68 properties
Ignore the individual commits, they're just how I did the change incrementally. I recommend reviewing the final state of provider.rs, maps.rs, and sets.rs
Basically, this introduces:
Each property gets a marker type like
WordBreakProperty. I decided to not call them Marker to avoid confusion.I've used a macro to make it easier to define these.
This does not touch the uniset or CPT crates; they can be renamed however we want them to be in the future. Note that right now this crate introduces a CodePointSet and CodePointMap data type that contains UnicodeSet and CodePointTrie respectively, if these names end up clashing in the future we can either unify the types or pick different names. I don't want to spend too much time making that call in this PR since it will be easy to make later and this PR is going to be changing a lot already.
This also doesn't version the names yet. I'm not 100% sure what we should version here; and this is also something that can be done separately.
(I'm trying to reduce the scope of this PR to just be complex typesystem stuff)
One major change here is that previously all setlike properties had the same return value; and now they are all separate types with marker types. This has the benefit of being ResourceMarker-compatible, however is this actually what is desired?
If this design looks good I'm going to go ahead and update the rest of the sets to use it (and update tests, etc)
thoughts? @echeran @sffc